Add report and CSV to SWY outputs list#224
Merged
megannissel merged 3 commits intonatcap:release/3.19.0from Apr 7, 2026
Merged
Add report and CSV to SWY outputs list#224megannissel merged 3 commits intonatcap:release/3.19.0from
megannissel merged 3 commits intonatcap:release/3.19.0from
Conversation
This was referenced Mar 23, 2026
newtpatrol
reviewed
Apr 7, 2026
|
|
||
| * **vri_sum** (units: mm/year): total recharge contribution (positive or negative) within the watershed. The sum of ``Vri_[Suffix].tif`` pixel values within the watershed. | ||
|
|
||
| * **geom_id**: a unique ID for the watershed |
Contributor
There was a problem hiding this comment.
Suggested change
| * **geom_id**: a unique ID for the watershed | |
| * **geom_id**: a unique ID for the watershed | |
| ``` * **geom_id**: a unique identification (ID) number for the watershed | |
| Several other similar places just show "geom_id" and then "ID" in the description, with no explanation of what "id" means, so i suggest adding the explicit description at least here, then we can just use the abbreviation in the description in subsequent mentions. It might be obvious to many of us, but not necessarily people who are not native english speakers. |
newtpatrol
approved these changes
Apr 7, 2026
Contributor
newtpatrol
left a comment
There was a problem hiding this comment.
This looks great to me @megannissel, i just added one small suggestion.
jagoldstein
approved these changes
Apr 7, 2026
Member
jagoldstein
left a comment
There was a problem hiding this comment.
LGTM, thanks! If anything else comes up, we can always adjust it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #223
This PR makes several updates to the model outputs list:
geom_idfield toaggregated_results_swy.shpAdditionally:
Outstanding questions: